+- QB64 Phoenix Edition (https://staging.qb64phoenix.com)
+-- Forum: Chatting and Socializing (https://staging.qb64phoenix.com/forumdisplay.php?fid=11)
+--- Forum: General Discussion (https://staging.qb64phoenix.com/forumdisplay.php?fid=2)
+--- Thread: Cleaning up the QB64 codebase (/showthread.php?tid=293)
Pages:
1
2
Cleaning up the QB64 codebase - justsomeguy - 05-01-2022
Hello
I have started down the journey of cleaning up the QB64 code base little by little. I have forked 'QB64-Phoenix-Edition/QB64pe:main'
Currently, I'm working on the qb64.bas. I'm mostly adding comments, and grouping related variables into structures. Needless to say it's going a bit slow.
My initial goals are:
- Make it easier to read and understand.
- Understand how it works, at very low level.
- Understand how to add features and commands.
- Optimize whenever possible.
If you have questions, comments or concerns, let me know.
Here is my GITHUB, so you track my progress.
Thanks
RE: Cleaning up the QB64 codebase - SMcNeill - 05-01-2022
(05-01-2022, 04:37 PM)justsomeguy Wrote:
- Understand how to add features and commands.
It's a little outdated, but try this for starters on that:
AddKeywords.pdf (Size: 795.12 KB / Downloads: 144)
RE: Cleaning up the QB64 codebase - justsomeguy - 05-01-2022
@SMcNeill That is a very good guide! I appreciate you sharing that. It will help in the documentation. If you have anymore of those insider guides, send them my way.
RE: Cleaning up the QB64 codebase - DSMan195276 - 05-01-2022
If I could make a suggestion, your branch already has lots of changes that are going to cause conflicts with things that others (like myself) are working on - I would recommend working on smaller parts in separate branches in your git repo and then submit them as PRs as you go along. That way we all can see what you're doing and get your changes incorporated into the main repository, and having smaller changes will make it much easier to review them and work around conflicts.
If you keep going as you are I think it's likely that by the end it will be extremely hard to merge your work. And that's fine if that's not your goal, but this is useful work and I'd definitely like to see improvements like this get incorporated into the main repository
RE: Cleaning up the QB64 codebase - justsomeguy - 05-02-2022
(05-01-2022, 11:48 PM)DSMan195276 Wrote: If I could make a suggestion, your branch already has lots of changes that are going to cause conflicts with things that others (like myself) are working on - I would recommend working on smaller parts in separate branches in your git repo and then submit them as PRs as you go along. That way we all can see what you're doing and get your changes incorporated into the main repository, and having smaller changes will make it much easier to review them and work around conflicts.
If you keep going as you are I think it's likely that by the end it will be extremely hard to merge your work. And that's fine if that's not your goal, but this is useful work and I'd definitely like to see improvements like this get incorporated into the main repository
I'm glad to see a few people are working on the codebase.
I don't plan on making any pull requests to the main repository, because it will be in heavy conflict with the current codebase.
RE: Cleaning up the QB64 codebase - TarotRedhand - 05-02-2022
(05-01-2022, 05:10 PM)SMcNeill Wrote:(05-01-2022, 04:37 PM)justsomeguy Wrote:
- Understand how to add features and commands.
It's a little outdated, but try this for starters on that:
Any chance that pdf can get included on the wiki?
TR
RE: Cleaning up the QB64 codebase - SMcNeill - 05-02-2022
Aye, but it really needs updating first.
RE: Cleaning up the QB64 codebase - RhoSigma - 05-02-2022
(05-02-2022, 10:24 AM)SMcNeill Wrote: Aye, but it really needs updating first.
Aye, even worse, it's a thread snapshot of the old qb64.org forum, hence property of the QB64 project (aka RCCola).
A rewrite from scratch would be required
RE: Cleaning up the QB64 codebase - SMcNeill - 05-02-2022
RC Cola can sue me. The BLEEPING BLEEP BLEEPER!! I'd be happy to take the matter to court as I really don't think some hidden notice in the corner of a webpage that nobody visits or could agree to, could possibly be binding and legal. Now, maybe if it was in one of the forum sign up pages where you clicky "Yes, I agree", but I don't think just writing something without having someone else sign to consent to it could be legally binding at all. If that's all it takes, I'm going to write a clause in all my books from now on -- "By reading, owning, copying, or publishing this drivel, Steve McNeill is now the sole owner of all your personal property and assets!" WOOT!
RE: Cleaning up the QB64 codebase - RhoSigma - 05-02-2022
(05-02-2022, 12:02 PM)SMcNeill Wrote: RC Cola can sue me. The BLEEPING BLEEP BLEEPER!! I'd be happy to take the matter to court as I really don't think some hidden notice in the corner of a webpage that nobody visits or could agree to, could possibly be binding and legal. Now, maybe if it was in one of the forum sign up pages where you clicky "Yes, I agree", but I don't think just writing something without having someone else sign to consent to it could be legally binding at all. If that's all it takes, I'm going to write a clause in all my books from now on -- "By reading, owning, copying, or publishing this drivel, Steve McNeill is now the sole owner of all your personal property and assets!" WOOT!
To be honest, on one of the last couple days of QB64.rip, when logging into the forum, I was in fact redirected to a page asking to give consens to the "new" Code of Conduct, with a link to that hidden page.